Skip to content

fix(copilot): use SDK 1.x permission decisions - #9

Open
vimoppa wants to merge 1 commit into
mainfrom
feature/fix-copilot-permission-contract
Open

fix(copilot): use SDK 1.x permission decisions#9
vimoppa wants to merge 1 commit into
mainfrom
feature/fix-copilot-permission-contract

Conversation

@vimoppa

@vimoppa vimoppa commented Jul 28, 2026

Copy link
Copy Markdown
Owner

What Changed

  • Map T3Code approval decisions to the GitHub Copilot SDK 1.x permission contract.
  • Reuse the same mapping for full-access sessions and pending requests cancelled during shutdown.
  • Add focused regression coverage for approve-once and reject decisions.

Why

The Copilot adapter was ported from an SDK 0.1.x integration but the dependency is now 1.0.7. It still returned the obsolete approved and denied-interactively-by-user outcomes, so Copilot accepted the user response and then failed every tool with an unexpected permission response error.

Using the SDK 1.x decision values fixes the contract at the shared adapter boundary for bash, glob, view, and every other Copilot tool.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

@github-actions github-actions Bot added size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S and removed size:XS labels Jul 28, 2026
@vimoppa vimoppa self-assigned this Jul 28, 2026
@vimoppa
vimoppa force-pushed the feature/fix-copilot-permission-contract branch from dd366ac to ee26567 Compare August 10, 2026 12:53
@github-actions github-actions Bot added size:XS and removed size:S labels Aug 10, 2026
@vimoppa
vimoppa force-pushed the feature/fix-copilot-permission-contract branch from ee26567 to 55f01e9 Compare August 10, 2026 13:11
@github-actions

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 55f01e9.

This comment will update automatically after the next completed run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant